determined-ai / determined

Determined is an open-source machine learning platform that simplifies distributed training, hyperparameter tuning, experiment tracking, and resource management. Works with PyTorch and TensorFlow.
https://determined.ai
Apache License 2.0
3k stars 350 forks source link

fix: display runs count in ProjectCard (ET-314) #9600

Closed johnkim-det closed 3 months ago

johnkim-det commented 3 months ago

Ticket

ET-314

Description

ProjectCard should display runs count instead of experiments count when Flat Runs feature flag is on.

Test Plan

With Flat Runs feature flag on

Checklist

netlify[bot] commented 3 months ago

Deploy Preview for determined-ui ready!

Name Link
Latest commit a2c57879c835aa73fff6511d83d83dc12d52c548
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6684347462908c00080bfb0e
Deploy Preview https://deploy-preview-9600--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.64%. Comparing base (84072f6) to head (a2c5787). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9600 +/- ## ========================================== - Coverage 51.36% 46.64% -4.72% ========================================== Files 1252 929 -323 Lines 152174 123056 -29118 Branches 3024 3051 +27 ========================================== - Hits 78158 57404 -20754 + Misses 73858 65496 -8362 + Partials 158 156 -2 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `?` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `48.61% <100.00%> (+0.63%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/determined-ai/determined/pull/9600?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [webui/react/src/components/ProjectCard.tsx](https://app.codecov.io/gh/determined-ai/determined/pull/9600?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Fcomponents%2FProjectCard.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL2NvbXBvbmVudHMvUHJvamVjdENhcmQudHN4) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [webui/react/src/types.ts](https://app.codecov.io/gh/determined-ai/determined/pull/9600?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Ftypes.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL3R5cGVzLnRz) | `99.68% <100.00%> (+<0.01%)` | :arrow_up: | ... and [328 files with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9600/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)