determined-ai / determined

Determined is an open-source machine learning platform that simplifies distributed training, hyperparameter tuning, experiment tracking, and resource management. Works with PyTorch and TensorFlow.
https://determined.ai
Apache License 2.0
2.93k stars 347 forks source link

fix: remove job move actions from webui #9603

Closed kkunapuli closed 1 week ago

kkunapuli commented 2 weeks ago

Ticket

RM-342

Description

Followup to https://github.com/determined-ai/determined/pull/9585, which removes the ability for users to update a job's queue position within the same priority group in the backend. Now that actions like "Move To Top" and repositioning a job within "Manage Job" have no effect, remove the buttons from the webui.

"Move to Top" on Resource Pool page should be removed and "Position in Queue" on "Manage Job" pop-up should be removed, as shown in the highlighted section in screenshots.

Test Plan

None needed.

Checklist

Screenshot 2024-07-02 at 2 03 37 PM Screenshot 2024-07-02 at 2 03 16 PM

netlify[bot] commented 2 weeks ago

Deploy Preview for determined-ui ready!

Name Link
Latest commit ef04804392fa86e062149e520c1e2890c0e29073
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668563374f0fa50008a4232a
Deploy Preview https://deploy-preview-9603--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.71%. Comparing base (95e090f) to head (0c294ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## job-queue-move #9603 +/- ## ================================================ Coverage 51.71% 51.71% ================================================ Files 1255 1255 Lines 152575 152447 -128 Branches 3091 3081 -10 ================================================ - Hits 78905 78844 -61 + Misses 73513 73446 -67 Partials 157 157 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9603/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/determined-ai/determined/pull/9603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `44.17% <ø> (+<0.01%)` | :arrow_up: | | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `72.76% <ø> (ø)` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9603/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `48.63% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/determined-ai/determined/pull/9603?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [master/internal/job/jobservice/jobservice.go](https://app.codecov.io/gh/determined-ai/determined/pull/9603?src=pr&el=tree&filepath=master%2Finternal%2Fjob%2Fjobservice%2Fjobservice.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-bWFzdGVyL2ludGVybmFsL2pvYi9qb2JzZXJ2aWNlL2pvYnNlcnZpY2UuZ28=) | `9.48% <ø> (+0.31%)` | :arrow_up: | | [webui/react/src/utils/job.ts](https://app.codecov.io/gh/determined-ai/determined/pull/9603?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Futils%2Fjob.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL3V0aWxzL2pvYi50cw==) | `78.26% <ø> (+1.46%)` | :arrow_up: | | [webui/react/src/pages/JobQueue/JobQueue.tsx](https://app.codecov.io/gh/determined-ai/determined/pull/9603?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Fpages%2FJobQueue%2FJobQueue.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL3BhZ2VzL0pvYlF1ZXVlL0pvYlF1ZXVlLnRzeA==) | `0.00% <0.00%> (ø)` | | | [webui/react/src/pages/JobQueue/ManageJob.tsx](https://app.codecov.io/gh/determined-ai/determined/pull/9603?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Fpages%2FJobQueue%2FManageJob.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL3BhZ2VzL0pvYlF1ZXVlL01hbmFnZUpvYi50c3g=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9603/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)