determined-ai / determined

Determined is an open-source machine learning platform that simplifies distributed training, hyperparameter tuning, experiment tracking, and resource management. Works with PyTorch and TensorFlow.
https://determined.ai
Apache License 2.0
3k stars 350 forks source link

chore: remove deprecated labels config option #9609

Closed kkunapuli closed 2 months ago

kkunapuli commented 3 months ago

Ticket

RM-343

Description

Label was deprecated and removed from agent configuration over a year ago. Reduce confusion by removing references from the code and docs.

If label is still present in an agent config, the following error message will be logged:

fatal error running Determined agent          error="cannot unmarshal configuration: error unmarshaling JSON: while decoding JSON: json: unknown field \"label\""

Test Plan

None needed.

Checklist

netlify[bot] commented 3 months ago

Deploy Preview for determined-ui ready!

Name Link
Latest commit 4129d211a0dc983bf294a093ff712d4f527a0846
Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668da70854491900087cd7b9
Deploy Preview https://deploy-preview-9609--determined-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.88%. Comparing base (262ad5a) to head (4129d21). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9609 +/- ## ======================================= Coverage 52.88% 52.88% ======================================= Files 1255 1255 Lines 153086 153084 -2 Branches 3230 3230 ======================================= Hits 80964 80964 + Misses 71971 71969 -2 Partials 151 151 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9609/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [backend](https://app.codecov.io/gh/determined-ai/determined/pull/9609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `44.00% <ø> (+<0.01%)` | :arrow_up: | | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `72.76% <ø> (ø)` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9609/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `51.30% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/determined-ai/determined/pull/9609?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [agent/cmd/determined-agent/init.go](https://app.codecov.io/gh/determined-ai/determined/pull/9609?src=pr&el=tree&filepath=agent%2Fcmd%2Fdetermined-agent%2Finit.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-YWdlbnQvY21kL2RldGVybWluZWQtYWdlbnQvaW5pdC5nbw==) | `100.00% <ø> (ø)` | | | [agent/internal/options/options.go](https://app.codecov.io/gh/determined-ai/determined/pull/9609?src=pr&el=tree&filepath=agent%2Finternal%2Foptions%2Foptions.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-YWdlbnQvaW50ZXJuYWwvb3B0aW9ucy9vcHRpb25zLmdv) | `29.09% <ø> (ø)` | | | [master/pkg/model/experiment\_config.go](https://app.codecov.io/gh/determined-ai/determined/pull/9609?src=pr&el=tree&filepath=master%2Fpkg%2Fmodel%2Fexperiment_config.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-bWFzdGVyL3BrZy9tb2RlbC9leHBlcmltZW50X2NvbmZpZy5nbw==) | `39.24% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9609/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)