feat: Add/remove HPs when creating experiment through HP search

gt2345 commented 1 week ago

Ticket

Description

Allow user to add or remove hyperparameters when creating experiment through HP search

Test Plan

Navigate to Hyperparameters tab of an experiment, click on the Hyperparameters Search button When selecting hyperparameters, add and remove hyperparameters Click on the Run Experiment button to create a experiment Verify that the new experiment is using the updated hyperparameters

https://github.com/determined-ai/determined/assets/40620519/a7e9d907-cd27-4a57-8932-78874eaefbae

Checklist

[ ] Changes have been manually QA'd
[ ] New features have been approved by the corresponding PM
[ ] User-facing API changes have the "User-facing API Change" label
[ ] Release notes have been added as a separate file under docs/release-notes/ See Release Note for details.
[ ] Licenses have been included for new code which was copied and/or modified from any external code

netlify[bot] commented 1 week ago

Deploy Preview for determined-ui ready!

Name	Link
Latest commit	c42732989a8e52ee92a053152479bd6a2d0a1663
Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66900905251cf60008bb9b21
Deploy Preview	https://deploy-preview-9610--determined-ui.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 87.69231% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.31%. Comparing base (98d574e) to head (c427329). Report is 29 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (98d574e) and HEAD (c427329). Click for more details.

HEAD has 9 uploads less than BASE
| Flag | BASE (98d574e) | HEAD (c427329) | |------|------|------| |harness|9|0|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9610 +/- ## ========================================== - Coverage 51.37% 46.31% -5.06% ========================================== Files 1252 929 -323 Lines 152174 123093 -29081 Branches 3023 3026 +3 ========================================== - Hits 78181 57015 -21166 + Misses 73835 65920 -7915 Partials 158 158 ``` | [Flag](https://app.codecov.io/gh/determined-ai/determined/pull/9610/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [harness](https://app.codecov.io/gh/determined-ai/determined/pull/9610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `?` | | | [web](https://app.codecov.io/gh/determined-ai/determined/pull/9610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | `48.01% <87.69%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/determined-ai/determined/pull/9610?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai) | Coverage Δ | | |---|---|---| | [...react/src/components/HyperparameterSearchModal.tsx](https://app.codecov.io/gh/determined-ai/determined/pull/9610?src=pr&el=tree&filepath=webui%2Freact%2Fsrc%2Fcomponents%2FHyperparameterSearchModal.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai#diff-d2VidWkvcmVhY3Qvc3JjL2NvbXBvbmVudHMvSHlwZXJwYXJhbWV0ZXJTZWFyY2hNb2RhbC50c3g=) | `89.54% <87.69%> (-0.38%)` | :arrow_down: | ... and [323 files with indirect coverage changes](https://app.codecov.io/gh/determined-ai/determined/pull/9610/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=determined-ai)

determined-ai / determined