Closed jesse-amano-hpe closed 2 months ago
Attention: Patch coverage is 0%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 52.88%. Comparing base (
000c679
) to head (06f0f61
). Report is 24 commits behind head on main.
Name | Link |
---|---|
Latest commit | 06f0f613de76c02079a905b97fc946e7d139d568 |
Latest deploy log | https://app.netlify.com/sites/determined-ui/deploys/669172ab9825630007fbfdac |
CE/SE question would be if this could break downstream integrations on that column name but since it's not accurate that's okay? alternative would be to make this a pure addition and avoid removing the "gpu_hours" column in the same release.
We discussed on Slack with @hkumar92 ; I'll add mention of this to release notes but no further mitigation should be needed.
Waiting on acceptance or response to https://hpe-aiatscale.atlassian.net/browse/DET-10408?focusedCommentId=32936
Ticket
DET-10408
Description
Renames the
gpu_hours
column in the allocation report CSV toslot_hours
as this is a more accurate description. Adds aresource_pool
column to help users identify what slot type(s) these slot-hours apply to.Test Plan
Run any number of experiments >0 on a cluster that has at least one slot configured. On cluster historical usage tab, make sure the end date is current, and click Download CSV.
Choose to group by Allocations and download the CSV
Observe
slot_hours
andresource_pool
columns are present in the downloadChecklist
docs/release-notes/
See Release Note for details.