dethcrypto / TypeChain

🔌 TypeScript bindings for Ethereum smart contracts
MIT License
2.73k stars 353 forks source link

[ethers-v5] Fix event and function signatures with tuples and array of tuples #847

Closed bernard-wagner closed 11 months ago

bernard-wagner commented 1 year ago

Expands on https://github.com/dethcrypto/TypeChain/pull/488 to add the some functionality for events.

Fixes https://github.com/dethcrypto/TypeChain/issues/785 and https://github.com/dethcrypto/TypeChain/issues/433 which might have been a regression.

Added a bit more tests, also added a test to ethers-v6 to make sure it already works as expected.

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 9298fa83f54818b42f05a45d52b01897e86a7548

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages | Name | Type | | --------------------- | ----- | | @typechain/ethers-v5 | Minor | | typechain | Minor | | test-e2e | Patch | | @typechain/hardhat | Patch | | @typechain/ethers-v6 | Patch | | @typechain/starknet | Patch | | @typechain/truffle-v5 | Patch | | @typechain/web3-v1 | Patch | | example-truffle-v5 | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

krzkaczor commented 11 months ago

Thanks for this change! Can u make sure that pnpm test:fix passes locally? (for example formatting fails)

bernard-wagner commented 11 months ago

Thanks for this change! Can u make sure that pnpm test:fix passes locally? (for example formatting fails)

Done. Hopefully it passes now.

krzkaczor commented 11 months ago

Thanks merged! Will be released soon.