Closed DainisGorbunovs closed 11 months ago
Latest commit: 5f8ac0376397512d69166b22f4e2a4877cea420e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There is an example for ethers-v6 could you begin with reproducing the problem in that example. I guess just updating deps just suffice. Ie. we need some kind of regression check to make sure this doesn't break in the future.
New dependencies detected. Learn more about Socket for GitHub ↗︎
Packages | Version | New capabilities | Transitives | Size | Publisher |
---|---|---|---|---|---|
@nomicfoundation/hardhat-ethers | 3.0.4 | None | +1 |
282 kB | fvictorio |
I've updated the following, and can confirm that the test passes:
@nomicfoundation/hardhat-ethers
package dependency version to 3.0.4To ensure the written code in counter.ts works properly, I've checked how it behaves in the older hardhat-ethers version, and also if I avoid using type annotation. In these cases, either the test errored, or returned an invalid number (note DeployContractOptions
allows us to override settings now). I've set gasPrice to a random number, and expect that it's set that way after deployment.
Superseded by: https://github.com/dethcrypto/TypeChain/pull/853
Thanks for this contribution! It will be released in a second.
This is merged now (needed a lint fix and a changeset added):
Issue
@nomicfoundation/hardhat-ethers@3.0.1 added support for transaction overrides in the
deployContract
helper.Specifically, these are the changes https://github.com/NomicFoundation/hardhat/commit/d8056fb8bc1116338f61974a8a44cd0defcb2555.
Here's issue raised in
hardhat
repository:Fix
Replaced
FactoryOptions
withDeployContractOptions
, and added import for it. Reran the tests to fix other files.Context
A new project is created:
It installs
@nomicfoundation/hardhat-ethers" v3.0.4. As hardhat uses [@typechain/ethers-v6](https://github.com/NomicFoundation/hardhat/blob/c2943366d4f16282c10f92f9f216ac08130a0eb4/yarn.lock#L1672), I've only updated
packages/target-ethers-v6/src/codegen/hardhat.ts`, which should be enough to resolve the issue.The provided
scripts/deploy.ts
contains:IDE complains about
{ value: lockedAmount }
. Third parameter inethers.deployContract
used to be forsignerOrOptions?: ethers.Signer | FactoryOptions
but was changed tosignerOrOptions?: ethers.Signer | DeployContractOptions
Visual Studio Code: