fix: `import type` now includes the module suffix.

dethcrypto / TypeChain

🔌 TypeScript bindings for Ethereum smart contracts

MIT License

2.73k stars 353 forks source link

fix: `import type` now includes the module suffix. #888

Open scnale opened 6 months ago

scnale commented 6 months ago

This is necessary for interpreters like ts-node or tsx that compile typescript just in time.

If you checkout this repository in this particular branch and run:

make dependencies
make build
npx tsc --noEmit --project tsconfig.json

You'll get errors for the import type directives because they're not pointing at modules nor have the .js suffix. If you build and link the typechain package in this branch, and run the yarn build-types command the codegen will be correct.

changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: c79da19985f3e77be31bd46143aff976d2353e31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR