Add bookmarklet to the readme

dethcrypto / dethcode

View source of deployed Ethereum contracts in VSCode

https://etherscan.deth.net/address/0xa3a7b6f88361f48403514059f1f16c8e78d60eec#code

1.36k stars 105 forks source link

Add bookmarklet to the readme #35

Closed hasparus closed 2 years ago

hasparus commented 2 years ago

What's changed?

Added a bookmarklet, admittedly very aggressive one, but I decided it's better to have something very simple and easy to trust than an overengineered monstrosity.
- There are tests for it. I wrote it directly in the readme initially and it obviously didn't work :P
Added a list of supported Etherscan instances to docs/supported-explorers.md and a script to generate them to ethereum-viewer package.

Depends on https://github.com/dethcrypto/ethereum-code-viewer/pull/34 to avoid conflicts.

Closes #33.

github-actions[bot] commented 2 years ago

Deploy preview for ethereum-code-viewer ready!

Built with commit d79d6e358bbcd0e5e6f3471d6b4f98b9d91257d9

✅ Preview: https://ethereum-code-viewer-b5sjoi4gx-dethcrypto.vercel.app

This pull request is being automatically deployed with vercel-action

github-actions[bot] commented 2 years ago

Deploy preview for ethereum-code-viewer ready!

Built with commit 8d59555c3596033ce8feba10082fe8c75d1bbf29

✅ Preview: https://ethereum-code-viewer-oyao6m6c2-dethcrypto.vercel.app

This pull request is being automatically deployed with vercel-action

krzkaczor commented 2 years ago

It's a good improvement and we can merge it for now but what I think dragging and dropping (as shown here: https://skogard.github.io/dethmark/) is even easier to use. Can we link to an explanation what bookmarklet is?

I think that we need to create a user extension anyway soon.

hasparus commented 2 years ago

I think dragging and dropping is even easier to use.

It's not universal, though: the user has to have a bookmarks bar, and we couldn't do that drag-and-drop from GitHub readme anyway.

I like @skogard's bookmarklet a lot, though, and there's definitely a place for his project and similar projects in ECV ecosystem. How about we feature in the readme similarly how GitHub1s does features 3rd party projects: https://github.com/conwnet/github1s#third-party-related-projects.