search

dethcrypto / dethcode

View source of deployed Ethereum contracts in VSCode
https://etherscan.deth.net/address/0xa3a7b6f88361f48403514059f1f16c8e78d60eec#code
1.35k stars 105 forks source link

Stop using hostname prefix in getApiName #68

Closed hasparus closed 2 years ago

hasparus commented 2 years ago

Should close #67.

I've been trying to see a contract source for rinkeby today, and I noticed we managed to break support for explorers other than mainnet etherscan when changing domains :> This should help, but I think we can test only after deploying prod.

Hostname prefix is now always code. and the explorer name comes from URLSearchParams.

krzkaczor commented 2 years ago

Thanks. I wanted to dive into this too. Lets see if this fix works.

hasparus commented 2 years ago

Duh, it seems it didn't help. The problem is somewhere deeper — we can't find a contract even if explorer is passed explicitly on code.deth.net.

https://code.deth.net/address/0x491d4F54871c752C1c772CE1f6aa8568f8eE8E4C?explorer=rinkeby.etherscan

I'm working around it with Cmd + Shift + P > Open smart contract source, so the part that detects the network seems to be broken.

krzkaczor commented 2 years ago

Deployment failed due to test errors. I'll fix it later today but feel free to jump in

krzkaczor commented 2 years ago

FIXD'!