search

dethcrypto / eth-sdk

Type-safe, lightweight SDKs for Ethereum smart contracts
MIT License
432 stars 40 forks source link

#98 Allow for descriminate-types options and other typechain flags #99

Closed ShravanSunder closed 2 years ago

ShravanSunder commented 2 years ago
changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 8a74669ffb5d0f0160b90cfe145382b9dc3e90cd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ShravanSunder commented 2 years ago

cc: @krzkaczor

ShravanSunder commented 2 years ago

@krzkaczor i'm unable to develop typechain due to pnpm issues, maybe we can mere this as is and make another PR for the default flags? I'll push change to the name of the flag

ShravanSunder commented 2 years ago

@krzkaczor made the change you suggested, if possible lets do the default change in a seperate PR? :)

krzkaczor commented 2 years ago

@ShravanSunder yes we can merge this but build failed. Can you take a look. And please pull before fixing it because I pushed changeset fix.

ShravanSunder commented 2 years ago

@krzkaczor fixed! 🙏🏽