dethrace-labs / dethrace

Reverse engineering the 1997 game "Carmageddon"
https://twitter.com/dethrace_labs
GNU General Public License v3.0
859 stars 44 forks source link

"Do it for me" upgrade option doesn't max out armor or power #273

Open rafalp opened 1 year ago

rafalp commented 1 year ago

Repro:

  1. Unlock "CHEAT!" APO upgrades
  2. Downgrade car
  3. Start race
  4. Select "Do it for me" option on upgrade prompt

Car's offense will be maxed out, but armor or power won't.

madebr commented 1 year ago

I cannot see a difference with OG. Can you please provide me with a save game, or state where there is a difference?

e.g.

credits: 999999
power_up_levels:
- 1
- 1
- 1
rafalp commented 1 year ago

I have max number of credits and base upgrades. I've went to record a video with repro and found that if I navigate to upgrades store, then re-load the save and then use the "do it for me" option, my car will be upgraded correctly. But when I start the game from zero, load the savegame with basic upgrades and navigate straight to the race but use the "do it for me" option along the way, the game will not fix it all out, eg:

https://user-images.githubusercontent.com/750553/208323420-ce44fae6-cdb2-477c-9888-be054e0163ff.mp4

Looks like initial global state is wrong and only fixed by visiting the upgrades screen?

rafalp commented 1 year ago

Here's video from scenario where visiting upgrades screen fixes the bug:

https://user-images.githubusercontent.com/750553/208323600-308a2218-89d9-42a2-9df2-9ec7f0be0018.mp4

madebr commented 1 year ago

The dos version also does not max out APO levels. Try this save game: save.zip

Even though it has 999999 credits, it will only buy 1xA, 2xP and 2xO.