search

dethrace-labs / dethrace

Reverse engineering the 1997 game "Carmageddon"
https://twitter.com/dethrace_labs
GNU General Public License v3.0
669 stars 38 forks source link

No smoke is drawn in right half of screen #310

Closed madebr closed 1 year ago

madebr commented 1 year ago

This happens in cockpit mode (320x200): DUMP0025 Also in hi-res mode (640x400): DUMP0025b This also happens with smoke emitted by opponents: DUMP0025c

Tested on current main: 35a4ce83dfb03e10f504416117410c4e381e90f8

dethrace-labs commented 1 year ago

Hmm, I cannot repro this on OSX. I'll check on my windows box. Could you check backwards to see when it was introduced? Maybe https://github.com/dethrace-labs/dethrace/pull/295 ?

madebr commented 1 year ago

It's ef9e4d668d799ab31b998a8e7877e36c8af4fe44

Look how the smoke stops at half the screen, but bleeds a little in the right half. DUMP0055

The fog depth effect also broke in the same commit. before: DUMP0056 after: DUMP0058

So perhaps the depth buffer is used/updated wrong?

madebr commented 1 year ago

Reducing the viewport by using the - key makes the smoke appear again.