search

dethrace-labs / dethrace

Reverse engineering the 1997 game "Carmageddon"
https://twitter.com/dethrace_labs
GNU General Public License v3.0
669 stars 38 forks source link

input: use PDKeyDown3 in PDGetASCIIFromKey #323

Closed madebr closed 1 year ago

madebr commented 1 year ago

PDKeyDown3 does not modify last_key_down and last_key_down_time

PDKeyDown3 is used in the german DOS Carmageddon executable, but not in the GOG splatpack Windows executable.

So I'm unsure what the correct approach is here.

Fixes #321

dethrace-labs commented 1 year ago

Interesting! I didn't look at the german executables at all :)

I think generally our approach should be to take the best implementation parts from all the different executables to provide the 'best' experience.

As long as we comment where and why we are deviating from the default OG source, I think its fine :)