search

dethrace-labs / dethrace

Reverse engineering the 1997 game "Carmageddon"
https://twitter.com/dethrace_labs
GNU General Public License v3.0
667 stars 38 forks source link

Improve support for the Brazilian Portuguese version #352

Closed leomontenegro6 closed 3 months ago

leomontenegro6 commented 8 months ago

A few months ago, I found out this cool reverse engineering project of Carmageddon. Glad it worked fine not only in PC, but also in some linux-based portable devices, such as Anbernic ones.

The original game works fine, but out of my curiosity, I tested if dethrace wouldn't, for some reason, support the Brazilian Portuguese version of this game, that features lots of texts and graphical changes, and even voice dubbing. It worked to some extend, but lots of menus were bugged. It worked in the Windows PC version, but crashed in Linux when I tried to run in my device with the binary compiled by PortMaster. Not sure if it's something from the compilation, or if it's really an issue with any dethrace linux versions.

Is there a chance we could improve dethrace to fully support this version?

madebr commented 8 months ago

I just tested dethrace of current master with the Portuguese game data, and some menus indeed cause a segmentation fault (e.g. the Race Selection Menu).

About the menus, if you're talking about the text disappearing and re-appearing when hovering your mouse, I think OG also has this. See this video: the text also disappears there. This behavior also occurs with German game data.

The options menu also looks bugged.

madebr commented 8 months ago

With #353, Portuguese dethrace does not crash anymore in the menus.

leomontenegro6 commented 8 months ago

Oh, that's pretty cool. I'll let PortMaster guys know about this update, and see if we can recompile it. Not sure if we're gonna do that with master, or after a new stable version is released with these changes.

About the YT video above, is there a difference between grabbing original game and merging the translated files with it, or getting all the data directly from a PT-BR ISO image? Is the result going to be the same, or did the author make some changes to accommodate the files with the original game?

madebr commented 8 months ago

I think the video author exclusively used the Portuguese game data. You can mix game data, as long as you somehow provide all requirements. (I think) the Portuguese carm95.exe is identical to the UK one, so the game data is very compatible.