ci: use libsdl-org/setup for SDL + package with CPack

dethrace-labs / dethrace

Reverse engineering the 1997 game "Carmageddon"

https://twitter.com/dethrace_labs

GNU General Public License v3.0

667 stars 38 forks source link

ci: use libsdl-org/setup for SDL + package with CPack #362

Closed madebr closed 3 months ago

madebr commented 3 months ago

Fix building dethrace from a source archive
Disable the test that accessed memory after it had been freed
use libsdl-org/setup-sdl for configuring SDL on ci
package release binaries with CPack

Normal ci output: https://github.com/madebr/dethrace/actions/runs/9244495833 Release ci output: https://github.com/madebr/dethrace/actions/runs/9245171693 Dummy release: https://github.com/madebr/dethrace/releases/tag/v0.0.69

dethrace-labs commented 3 months ago

Looks nice! The windows packages are missing SDL2.dll though, which we should include. Also, for the macos package, I think having the LICENSE file in the root of the archive like windows rather than in a /share/.. directory is more expected.

In the future we'll need to move the macos target to build a proper .app package with icon and SDL2 libraries packaged. I was looking at https://github.com/diasurgical/devilutionX/releases/tag/1.5.2, they had a lot of targets and it would would be great to build our infrastructure in a way that we could end up with something similar :)

madebr commented 3 months ago

Made it install to the root for all packages. CPack by default creates a subdirectory, which I think is ok. wdyt?

About creating a .app package, I think we need to do set_property(TARGET dethrace PROPERTY MACOSX_BUNDLE TRUE). I think you can then add libSDL2.dylib to it (and configure dethrace's runpath such that it can actually find SDL2)