Original music - Githubissues

dethrace-labs / dethrace

Reverse engineering the 1997 game "Carmageddon"

https://twitter.com/dethrace_labs

GNU General Public License v3.0

667 stars 38 forks source link

Original music #393

Closed dethrace-labs closed 1 month ago

dethrace-labs commented 1 month ago

Adds support for music as in the GOG release. That is, MUSIC/Track0[1-8].ogg files. If they exist, the original CD audio functions are redirected to play the ogg files.
Adds stb_vorbis to enable vorbis support in miniaudio
Switches miniaudio to use the default header-only implementation (to make it work with vorbis)
Fixes bug in sound options where the dials are both initially set to the music volume

Fixes #278

dethrace-labs commented 1 month ago

I'm not sure assert is the right approach in S3GetDescriptorByID because it is removed when building a Release build. But LGTM!

That was my sort of my intention. The check is not present in the original code, but the assert could be helpful if we are working on the audio code in the future and break something