Display player aliases on stats cards

dethredic / WC3StreamerOverlay

A simple tool for wc3 streamers to display their opponent's race and stats

GNU General Public License v3.0

30 stars 7 forks source link

Display player aliases on stats cards #5

Closed ghost closed 5 years ago

ghost commented 5 years ago

wc3overlay

Added feature to display a player's alias on their stats cards if they have one.
Displays as '[Main name] aka [alt name]' eg 'Grubby as FollowGrubby'.
Known issue: long 'known as' names wrap onto a second line, which doesn't look very good.

Player's known aliases are extracted from data at https://warcraft3.info/stats/player and saved in src/aliases.json. I've also included the script I used to scrape the aliases from warcraft3.info, they track about 1300 players at the moment but only have 300 recorded aliases. The script only needs to be run occasionally when the data on warcraft3.info is updated, the distributed aliases.json should be good enough for most users.

Let me know if you have any feedback or suggestions.

dethredic commented 5 years ago

Awesome, thanks for this! I also just tweaked the layout after some streamer feedback so can you double check it still looks good? Can you also update the README.md to remove the TODO I have at the bottom?

ghost commented 5 years ago

@dethredic It still looks alright after merging your changes, I think it would look better if there was less space between the two lines of text but I really don't want to do any CSS at all. I will start to work through your feedback today and tomorrow.

dethredic commented 5 years ago

@dethredic It still looks alright after merging your changes, I think it would look better if there was less space between the two lines of text but I really don't want to do any CSS at all. I will start to work through your feedback today and tomorrow.

Try playing around with the grid spacing: https://github.com/dethredic/WC3StreamerOverlay/blob/master/client/src/components/player.js#L20 8 or 0 might look better.

You could also try wrapping the name / aka elements in a grid and set the spacing there to 0 (so there is still some space between the name and stats)

You can also play around with the gutterBottom prop with typography elements

dethredic commented 5 years ago

New changes look great! Just update the READMe.md (there is a todo for this at the bottom you can remove).

If you don't want to play around with the UI I'll merge this and play around with it tomorrow. EDIT: I played around with things and I think this looks pretty good: test_aka

After your change lands I'll apply my UI tweaks

JFGHT commented 5 years ago

Question: wouldn't it be better a transparent background?

dethredic commented 5 years ago

Question: wouldn't it be better a transparent background?

It's already only 70% opaque. I'll play around with adding more transparency. The game has a lot of textures so I think 100% transparency would make the text hard to read sometimes

dethredic commented 5 years ago

Just gonna merge this and fix the last thing in my UI change

ghost commented 5 years ago

Sorry I've been busy this week and not had time to work on this.

I thought I had included a filter for the name == alias in the backend but it looks like I missed that.

dethredic commented 5 years ago

Sorry I've been busy this week and not had time to work on this.

I thought I had included a filter for the name == alias in the backend but it looks like I missed that.

No problem. I had some free time and figured I would run with it. Thanks for doing this, the streamers have been asking for this feature!