detleph / server

Server component of the Detleph event management system
MIT License
1 stars 0 forks source link

Routes are non-standard #65

Closed stephan418 closed 2 years ago

stephan418 commented 2 years ago

https://github.com/detleph/server/blob/eff81e32f1b2ce6c30f2128d439c5b16550f1f84/src/Routes/participant.routes.ts#L16

The PID is specified after /teams but represents a participant? Wouldn't /participants/:pid or /teams/:teamPid/participants/:pid make more sense?

Also: please use participants instead of participant (collections are always plural)

Flexla54 commented 2 years ago

Done