search

detleph / server

Server component of the Detleph event management system
MIT License
1 stars 0 forks source link

Using a request body in GET requests is highly non-standard #68

Closed stephan418 closed 2 years ago

stephan418 commented 2 years ago

https://github.com/detleph/server/blob/80b09ebf5af72902455a17bb8bc47dddad8646a9/src/Controllers/user_auth.controller.ts#L97

Stefan-5422 commented 2 years ago

If I understand this correct you want a lib that can handle this in a standardized way?

stephan418 commented 2 years ago

No, but POST should be used when there is a body. But this doesn't have to be fixed right away as the priority should be finishing the server today

stephan418 commented 2 years ago

@Flexla54 is this fixed (currently not a high priority as it would require rewriting parts of the API client) or is this closed as WONTFIX?