detleph / server

Server component of the Detleph event management system

MIT License

1 stars 0 forks source link

Team registrations are often not relateable #87

Closed Flexla54 closed 1 year ago

Flexla54 commented 2 years ago

It's hard to interpret registrations as failed or real. I'm convinced that

adding a registration time to the table and
outsourcing a pending registration to redis (a failed registration, due to eg mail not working, shouldn't be in the postgres db)

would make the life of the registration validators just easier.

I know that it might be a bit late for this, however this site is planned to run for other events too.

stephan418 commented 2 years ago

I agree with the premise (and the first point), however I do not know if it makes sense to store pending registrations in redis (as this would cause development overhead because of the change in paradigms).

It might just be easier to just check weather the verified boolean is set to true on the team

Flexla54 commented 2 years ago

Won't the data corpses in the database be a problem?

stephan418 commented 2 years ago

Won't the data corpses in the database be a problem?

I don't see a specific reason why they would be? There should of course be some logic that deletes them after some time, but other than that...

Do you see any other problems?

Flexla54 commented 2 years ago

Ok thats fine by me!

I thought that redis is already used for pending teamleader authentication, so I thought it would be efficient to combine them.

stephan418 commented 2 years ago

Outgoing task definition:

[x] Add registration time to the team model
[x] Use the verified flag in a way that helps reviewers (Only show unverified people on request for example)
[x] Add ability to purge stale data after event
[x] Test the new feature/fix on basic functionality

Flexla54 commented 1 year ago

So i basically implemented it.

However i want to note that the _deleteUnverifiedTeams function should be used when the sign in phase ends.