Tests fail under Python 2.7

[jfsantos]

Using the same codebase and Python 2.7, 27 of the 91 tests fail. All of them are in the tests/test_fft_weights.py file. Do you have any idea on what could be causing this?

[detly]

It's written for Python 3. They're quite likely syntax errors. On 29/12/2014 8:42 AM, "João Felipe Santos" notifications@github.com wrote:

Using the same codebase and Python 2.7, 27 of the 91 tests fail. All of them are in the tests/test_fft_weights.py file. Do you have any idea on what could be causing this?

— Reply to this email directly or view it on GitHub https://github.com/detly/gammatone/issues/3.

[jfsantos]

Would you be interested in keeping a compatible codebase for Python 2 and 3? I could help fixing those. It seems it's the only place where there are issues (even though they are carried through the other functions, of course).

[detly]

I wouldn't mind maintaining a port for Python 2.7, but I don't have time right now to do the initial conversion. If you (or anyone) did that in a separate branch, I'd be happy to take the pull request and keep it up to date with future work. On 29/12/2014 8:55 AM, "João Felipe Santos" notifications@github.com wrote:

Would you be interested in keeping a compatible codebase for Python 2 and 3? I could help fixing those. It seems it's the only place where there are issues (even though they are carried through the other functions, of course).

— Reply to this email directly or view it on GitHub https://github.com/detly/gammatone/issues/3#issuecomment-68220860.

[jfsantos]

4 contains a fix for this. It was easier than I expected.

[detly]

Can you confirm that this is also closed now?

[jfsantos]

Yes, this is closed by #4.