search

detroitledger / gnl-react

0 stars 0 forks source link

Switch to eslint #1

Open hampelm opened 7 years ago

hampelm commented 7 years ago

http://eslint.org/

jshint doesn't like JSX

bnchdrff commented 7 years ago

agree.

i put a config in package.json and it's in node_modules/.bin/eslint but i don't have a runner set up

how about we run it with npm test before our other tests (of the future) run?

npm test could invoke a script test.sh that looks like this:

#!/usr/bin/env bash

echo 'eslint should not report any errors...'
./node_modules/.bin/eslint .
if [ "$?" != "0" ]; then
  echo "eslint failed." 1>&2
  exit 1
fi

echo 'jest tests should pass...'
./node_modules/.bin/jest
if [ "$?" != "0" ]; then
  echo "jest failed." 1>&2
  exit 1
fi