search

detroitledger / gnl_profile

API & data management system for the Detroit Ledger
https://www.detroitledger.org
0 stars 2 forks source link

Figure out why we don't have Harriet Tubman data #140

Closed hampelm closed 8 years ago

hampelm commented 8 years ago

EIN 10885325 Guidestar has 'em http://www.guidestar.org/profile/01-0885325

hampelm commented 8 years ago

Ah, we don't have the leading zero.

bnchdrff commented 8 years ago

why don't we just cast to int before the api request?

hampelm commented 8 years ago

That would work. I'd like us to be as true to the source data as possible (will help if we have other consumers in the future, too)

bnchdrff commented 8 years ago

i'm fairly positive that an EIN is always a number and never requires symbols. according to wikipedia the dash after the first two digits is a cosmetic choice. we can display the ein with a dash but i think it makes sense to store & query as a number.

hampelm commented 8 years ago

Ah! Could we cast the EIN to an int server-side? And maybe also remove dashes. That way it wouldn't matter if the requester had the leading zero.

bnchdrff commented 8 years ago

we could def do that!

On Wed, Sep 7, 2016 at 9:05 AM, Matt Hampel notifications@github.com wrote:

Ah! Could we cast the EIN to an int server-side? And maybe also remove dashes. That way it wouldn't matter if the requester had the leading zero.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/detroitledger/gnl_profile/issues/140#issuecomment-245274001, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGDennB0HQGb_SendIRio9nPSxLPV8Mks5qnrargaJpZM4JxDWY .