detunized / lastpass-ruby

LastPass Ruby API
MIT License
70 stars 19 forks source link

Support for HTTParty Proxy Options - Fixes #3 #6

Closed chrisdambrosio closed 9 years ago

chrisdambrosio commented 9 years ago
LastPass::HTTP.http_proxy(address, port)

or

LastPass::HTTP.http_proxy(address, port, username, password)
coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.19%) when pulling c5e53868844035a29466d572863e1cace8235aaa on chrisdambrosio:proxy_support into a2a3e5b7c06cf015ece1bf6ba78003160da65f63 on detunized:master.

detunized commented 9 years ago

Chris, thanks for the contribution! I'm gonna merge this. But I would like to add a standard comment header for the new files you've created first. For this project I use this:

# Copyright (C) 2013 Dmitry Yakimenko (detunized@gmail.com).
# Licensed under the terms of the MIT license. See LICENCE for details.

There's a number of ways this can be approached:

  1. Use the same header
  2. Replace my name/email with yours
  3. Change it to something different like Dmitry Yakimenko and coauthors and I'll later replace it everywhere else as well to keep it uniform
  4. Some other option

What do you think?

chrisdambrosio commented 9 years ago

No problem, I added the headers =)

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.19%) when pulling cdbdb4e7d04a639bf0952bfe599d05be2a4c9844 on chrisdambrosio:proxy_support into a2a3e5b7c06cf015ece1bf6ba78003160da65f63 on detunized:master.

detunized commented 9 years ago

Great work, thanks!