search

deu / palemoon-overlay

Unofficial Gentoo overlay for the Pale Moon (http://www.palemoon.org/) web browser.
34 stars 12 forks source link

USE=-jemalloc has no effect on the build #129

Open cyborgyn opened 2 years ago

cyborgyn commented 2 years ago

It still builds with jemalloc included. This is because probably it's enabled in mozbuild by default, so I propose to use in the ebuild

    if ! use jemalloc; then
        mozconfig_disable jemalloc
    fi

instead of 

    if use jemalloc; then
        mozconfig_enable jemalloc
    fi
Richard-Rogalski commented 5 months ago

It's a shame that this isn't resolved yet, like honestly.

jemalloc is enabled by default. enabling it or leaving no config for it, it's the same thing.

anyways, for any ebuild, nothing should ever be embiguous. For every build config, it should always be explicit. --enable-jemalloc or --disable-jemalloc, never blank.

this is because many build options are 'automagic' and done based on what the build script can infer from the user's system, leading to ebuilds working on one machine and not another. Even when not, default can change over time.