deu / palemoon-overlay

Unofficial Gentoo overlay for the Pale Moon (http://www.palemoon.org/) web browser.
34 stars 12 forks source link

Disable gold in mozconfig #141

Closed annulen closed 1 month ago

annulen commented 1 month ago

After switching to profile amd64/23.0 I've discovered that palemoon failed to rebuild. It turned out that Palemoon uses ld.gold for linking by default if it's found in the system (which is true in my case), and new 23.0 profile now has -Wl,-z,pack-relative-relocs in LDFLAGS, which is not supported by ld.gold. It seems to me that disabling gold would be the right thing to do, as it can only lead to slightly larger linking times which is not crucial here.

l29ah commented 1 month ago

I cannot reproduce it on 33.1.1 despite having both ld.gold installed and using a amd64/23.0/split-usr/hardened profile.

annulen commented 1 month ago

Without the patch I'm getting following error in build.log:

DEBUG: /var/tmp/portage/www-client/palemoon-33.1.1/work/palemoon-33.1.1/o/build/unix/gold/ld: pack-relative-relocs: unknown -z option
l29ah commented 1 month ago

Turns out i don't have ld.gold installed, just a stale symlink. Will apply the patch shortly, thanks.