Radix new version - Githubissues

rcchcz commented 3 years ago

This PR implements the code for radix sort in C++ -- this version of radix orders both non-negative and negative integers.

I have read the contributing guidelines in CONTRIBUTING.md and have ensured the following:

[X] My code is placed in the required directory as outlined in CONTRIBUTING.md
[X] My code file is named according to CONTRIBUTING.md
[X] Variables, classes, functions etc. follow camel case as outlined in CONTRIBUTING.md
[X] My code hasn't been implemented or claimed by someone else and I have checked the present issues and PRs for the same
[X] My code is well commented
[X] If my code is the first implementation of radix sort, I have added the link to this directory in README.md
[X] I have not copied my code from anywhere

rcchcz commented 3 years ago

Could you help me with this? Is there any way to change this in the pull request made or should I make a new one?

deutranium commented 3 years ago

Just committing in the same branch (radix-new-version in this case) will automatically add it to the PR

codelixir commented 3 years ago

@deutranium I would suggest you clarify this underscore convention in the main README because otherwise, it looks like we are strictly enforcing camel case; so I think this exception should be pointed out.

There was a lot of confusion in #174 as well due to the same thing.

deutranium commented 3 years ago

@codelixir I was thinking more towards having camel case as the general naming convention and specifying any optional attributes/modifications (like compatibility with negative numbers in this case) should be done using a separator(_ here) to distinguish it from the main algorithm name

Could you make a PR/issue to add the same to README.md?

codelixir commented 3 years ago

@deutranium check if #228 looks good, sorry for the delay.

deutranium / Algorithms

Radix new version #191