deutranium / Algorithms

Short explanations and implementations of different algorithms in multiple languages
48 stars 98 forks source link

Palindrome using iterators #196

Closed rcchcz closed 3 years ago

rcchcz commented 3 years ago

This PR implements the code for palindrome checker in C++. This version uses iterators and has a different strategy.

I have read the contributing guidelines in CONTRIBUTING.md and have ensured the following:

codelixir commented 3 years ago

Hey, @rcchcz! The code looks good, just one tiny change - please change the name of the file to something like palindrome_WithIterators.cpp (following @deutranium's comment on #191).

Also, according to this repo's CONTRIBUTING.md, you are supposed to comment on the corresponding issue (#161 in this case) before making a PR.

It's okay, I'll merge it this time once you make the change, but please keep this in mind in the future : )

rcchcz commented 3 years ago

Oh, my mistake, sorry! I'll fix it now. Thanks!

deutranium commented 3 years ago

Looks great, thanks for contributing!