dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
14 stars 37 forks source link

Background slider eniola ademola #10

Closed EniolaAdemola closed 9 months ago

EniolaAdemola commented 9 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After

image |

netlify[bot] commented 9 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit dea10d3d4f181920a591f25e5fbdf675a29c66ec
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/652125bdd802be0008591ebc
Deploy Preview https://deploy-preview-10--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 9 months ago

Pull Request Report

Hello! Here's a report for the pull request:

Changes

  1. Modified ProjectList.json:
    • Added a new project called "Background Slider" by Eniola Ademola.
    • Added tags for the new project: html, css, js.
    • Updated the description for the "Payment Gateway System" project.
  2. Added index.html for the "Background Slider" project.
  3. Added script.js for the "Background Slider" project.
  4. Added style.css for the "Background Slider" project.

Suggestions to Improve Code

  1. In index.html for the "Background Slider" project:
    • Consider using a CDN link for the Font Awesome library instead of a local file.
    • Add a comment to explain the purpose of each section in the HTML structure.

Bugs

No bugs found.

Improvements

  1. In script.js for the "Background Slider" project:
    • Consider using const instead of let for the body variable.
    • Add comments to explain the purpose of each function and event listener.
    • Use template literals for the URLs in the setBgToBody function to improve readability.

Rating

I would rate the code a 7 out of 10. The code is generally readable and performs well. However, there are some areas that could be improved for better readability and maintainability.

That's it for the report! Let me know if you need any further assistance.