dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
14 stars 37 forks source link

Created QuizApp #14

Closed dhruvpal05 closed 9 months ago

dhruvpal05 commented 9 months ago

Describe your change: This is a small QuizApp which includes question on html, css and javascript.

Checklist:

ATTACH SCREEN-SHOTS

Before After
< Before Image > < After Image >
netlify[bot] commented 9 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit c9ea2435900d5aa1b88cc7693ce3d7d66e5a339a
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/65212bece4869f0008d46de8
Deploy Preview https://deploy-preview-14--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 9 months ago

Pull Request Report

Greetings! πŸ‘‹

Here is the report for the pull request:

Changes:

  1. Added index.html file with the initial structure of the Quiz App.
  2. Added script.js file with the logic for loading and displaying quiz questions.
  3. Added style.css file with the styling for the Quiz App.

Suggestions to improve code:

  1. Consider using more descriptive variable names in the script.js file to improve code readability.
  2. Add comments to explain the purpose and functionality of different sections of code in the script.js file.

Bugs:

No bugs found.

Improvements:

  1. In the style.css file, consider using more specific selectors to avoid potential conflicts with other stylesheets.
  2. In the script.js file, consider using a more modular approach by separating the quiz logic into separate functions for better readability and maintainability.

Code Refactoring:

In the script.js file, the loadQuiz function can be refactored for better readability:

function loadQuiz() {
    deselectAnswers();

    const currentQuizData = quizData[currentQuiz];

    questionEl.innerText = currentQuizData.question;
    a_text.innerText = currentQuizData.a;
    b_text.innerText = currentQuizData.b;
    c_text.innerText = currentQuizData.c;
    d_text.innerText = currentQuizData.d;
}

Rating:

I would rate the code a 7 out of 10. The code is generally readable and well-structured. However, there are some areas where improvements can be made to enhance code readability and maintainability. Additionally, further optimizations can be done to improve performance and security.

That's all for the report! Let me know if you need any further assistance. πŸ˜„

dev-AshishRanjan commented 9 months ago

@dhruvpal05 , I Merged this PR,

Please follow the Contribution Guideline present in : https://github.com/dev-AshishRanjan/Hacktoberfest-Frontend/blob/dev/CONTRIBUTING.md

To Do :

  1. ADD your project details in contribution/ProjectList.json

After doing this, create a new PR