dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
14 stars 37 forks source link

Faq eniola ademola #17

Closed EniolaAdemola closed 9 months ago

EniolaAdemola commented 9 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After
< Before Image > < After Image >
netlify[bot] commented 9 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit e1f9ccdd0b404ae292ec2ef1bacb8c84fad960f1
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/6521530cd802be00085a8220
Deploy Preview https://deploy-preview-17--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 9 months ago

Pull Request Report

Hey there! I've created a report for the pull request. Let's dive in!

Changes

  1. Modified ProjectList.json:

    • Added a new project "Animated Navigation" by Eniola Ademola.
    • Updated the tags for the "Payment Gateway System" project.
  2. Added new files:

    • index.html for the FAQ Collapse project.
    • style.css for the FAQ Collapse project.
    • script.js for the FAQ Collapse project.

Suggestions

I have a few suggestions to improve the code:

  1. In index.html for the FAQ Collapse project, consider adding a DOCTYPE declaration at the beginning of the file.

  2. In index.html for the FAQ Collapse project, you can remove the integrity and crossorigin attributes from the <link> tag for the font-awesome stylesheet. These attributes are not necessary for local files.

  3. In style.css for the FAQ Collapse project, you can remove the @import rule for the Google Fonts stylesheet. Instead, you can directly link the stylesheet in the HTML file.

Bugs

I couldn't find any potential bugs in the code. Great job!

Improvements

I found a couple of places in the code that could be refactored for better readability:

  1. In script.js for the FAQ Collapse project, you can use arrow function syntax for the event listener callback function. Here's the updated code snippet:

    const toggles = document.querySelectorAll(".faq-toggle");
    
    toggles.forEach((toggle) => {
     toggle.addEventListener("click", () => {
       toggle.parentNode.classList.toggle("active");
     });
    });
  2. In style.css for the FAQ Collapse project, you can remove the duplicated border-box property from the universal selector (*). It's already defined in the body selector.

Rating

I would rate the code a 7 out of 10 based on the following criteria:

That's it for the pull request report! Let me know if you need any further assistance. Keep up the good work! 👍