dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
14 stars 37 forks source link

Shopping cart #27

Closed FaithNjah closed 9 months ago

FaithNjah commented 9 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After
< Before Image > < After Image >
netlify[bot] commented 9 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit d994dddebaaf468d94659d84af627ddfd069b5fa
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/65221dd16f7e050008c5d994
Deploy Preview https://deploy-preview-27--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 9 months ago

Pull Request Review - Summary

Hey there! 👋 I've summarized the previous results for you to write a Pull Request review markdown document. Let's get started!

Changes ✨

  1. Added a new project 'ShoppingCart' by Faith Njah.
  2. Added images for the 'ShoppingCart' project.
  3. Added a new HTML file 'index.html' in the 'projects/ShoppingCart' directory.
  4. Added Bootstrap CSS library from a CDN.
  5. Linked a custom CSS file 'index.css'.
  6. Added a navbar with links to Home, Product, About, Page, Blog, and Contact.
  7. Added a carousel with three images.
  8. Added a product section with six items.
  9. Added a footer section.

Suggestions 🤔

  1. In 'ProjectList.json', consider using consistent indentation for better readability.
  2. In 'index.css', consider adding a newline at the end of the file for consistency.

Bugs 🐛

  1. Potential bug: In 'index.html', there is a missing closing </div> tag at line 47.
  2. Potential bug: In 'index.html', there is a missing closing </html> tag at the end of the file.

Improvements 🚀

In 'index.html', the footer section can be refactored for better readability:

<footer>
  <div class="container">
    <div class="row">
      <div class="col-12 col-md-3">
        <h4>About Us</h4>
      </div>
      <div class="col-12 col-md-3">
        <h4>Contact Us</h4>
      </div>
      <div class="col-12 col-md-3">
        <h4>Shop Category</h4>
      </div>
      <div class="col-12 col-md-3">
        <h4>Partners</h4>
      </div>
    </div>
  </div>
</footer>

Rating ⭐️

Overall rating: 7.5/10

Criteria:

That's it! You can now use this summary to write your Pull Request review markdown document. Good luck! 🚀

FaithNjah commented 9 months ago

Hi @dev-AshishRanjan, I have created a PR, kindly check and merge