dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
15 stars 36 forks source link

Resolve the issue-(#16) of Contact Page. #29

Closed Aka-suvam closed 12 months ago

Aka-suvam commented 12 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After
< Before Image > < After Image >

< After Image> screen-capture ..webm

netlify[bot] commented 12 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit cca0508ae1209a44522b385c6a9a018400a16de1
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/6522457916cddd0008a3faf0
Deploy Preview https://deploy-preview-29--frontend-database.netlify.app/contact
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 12 months ago

Pull Request Report

Hey there! 👋 Here's the report for the pull request:

Changes

  1. Updated the contact.html file.
  2. Made changes to the form inputs for name, email, subject, and msg.

Suggestions to Improve Code

  1. Line 64: Consider adding a pattern attribute to the name input field to enforce a specific format for the name.
  2. Line 65: The maxlength attribute for the email input field seems too restrictive. Consider increasing the limit to allow longer email addresses.
  3. Line 66: Similar to the email input field, the maxlength attribute for the subject input field could be increased to accommodate longer subjects.
  4. Line 68: The maxlength attribute for the msg textarea seems too short. Consider increasing the limit to allow for longer messages.

Bugs

No bugs found in the code.

Improvements

  1. Line 62: Add the required attribute to the name input field to make it mandatory for users to enter their name.
  2. Line 63: Similarly, add the required attribute to the email input field to make it mandatory for users to enter their email address.
  3. Line 64: Add the required attribute to the subject input field to make it mandatory for users to enter a subject.
  4. Line 68: Add the required attribute to the msg textarea to make it mandatory for users to enter a message.
  5. Line 68: Consider increasing the maxlength attribute value for the msg textarea to allow for longer messages.

Code Refactoring for Better Readability

No specific code snippet provided for refactoring.

Rating

I would rate the code as follows:

Overall, the code looks good with minor suggestions for improvement. Keep up the great work! 😄