dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2024 in the Web domain specially Frontend. And give this repo a ⭐

https://frontend-database.netlify.app

MIT License

18 stars 41 forks source link

added lazy loader #31

Closed krishna050702 closed 1 year ago

krishna050702 commented 1 year ago

Describe your change:

[x] Add a Project?
[ ] Fix a bug or typo in an existing Projects?
[ ] Documentation change?

Checklist:

[x] I have read CONTRIBUTING.md.
[x] This pull request is all my own work -- I have not plagiarized.
[x] I know that pull requests will not be merged if they fail the automated tests.
[x] This PR only changes one Project folder. To ease review, please open separate PRs for separate algorithms.
[x] All new Project files are placed inside an existing directory.
[x] If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] The title of my pull request is a short description of the requested changes.
[x] I have made corresponding changes to the documentation
[ ] My PR needs documentation change

ATTACH SCREEN-SHOTS

Before	After
< Before Image >	< After Image >

netlify[bot] commented 1 year ago

Deploy Preview for frontend-database ready!

Name	Link
Latest commit	bd94b5bd79ed3227ca6c891ee8b924e73bb34b3e
Latest deploy log	https://app.netlify.com/sites/frontend-database/deploys/65225a9c94dfc3000845e50c
Deploy Preview	https://deploy-preview-31--frontend-database.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Hello! Here's the report for the pull request:

Changes

Added a new project called "Lazy-loader" by Krishna Mundada.
Added the necessary files for the "Lazy-loader" project.

Suggestions to Improve Code

In app.js:
- Consider using more descriptive variable names instead of loadText, background, load, int, blurring, and scale.
- Add comments to explain the purpose of each section of code.
In index.html:
- Add a favicon to the <head> section.
- Consider adding a <noscript> tag to provide alternative content for users who have JavaScript disabled.

Bugs

No bugs found.

Improvements

In style.css:
- Remove the unused fill property in the .background class.

Rating

I would rate the code a 7 out of 10. The code is generally readable and performs well. However, there are some areas that could be improved for better readability and maintainability.

That's it for the report! Let me know if you need any further assistance.