dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
15 stars 36 forks source link

improvements: updated the UI to clear after 1m, added download QR option #34

Closed Ejay02 closed 12 months ago

Ejay02 commented 12 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After
< After Image >

image

netlify[bot] commented 12 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit a9a8e3da8f4bd99dfe635da0a881ef9405d923bf
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/6522739c3dcee000082f98f7
Deploy Preview [https://deploy-preview-34--frontend-database.netlify.app/projects/qr code generator](https://deploy-preview-34--frontend-database.netlify.app/projects/qr code generator)
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 12 months ago

Pull Request Report

Hey there! I've created a report for the pull request. Let's dive in!

Changes

  1. Added a step to download the QR Code file in the README.md file.
  2. Updated the UI in index.html to display "Enter Text" instead of "Enter text or URL" and allow entering numbers as well.
  3. Changed the button text in index.html to "⚡Generate QR Code".
  4. Added functionality to change the button text to "Download" and add a download function in index.js.
  5. Added functionality to clear the QR code and input field after 2 minutes in index.js.

Suggestions

  1. It would be helpful to provide a brief description of the changes made in the commit messages for better understanding.

Bugs

  1. No bugs found.

Improvements

  1. Consider using more descriptive variable names in index.js for better readability.
  2. Add comments to explain the purpose of each function and section of code in index.js.

Rating

I would rate the code a 7 out of 10. The code is generally readable and performs well. However, there is room for improvement in terms of variable naming and code documentation.

That's it for the report! Let me know if you need any further assistance. Have a great day!