dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2024 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
18 stars 41 forks source link

typing speed check game added #36

Closed krishna050702 closed 1 year ago

krishna050702 commented 1 year ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After
< Before Image > < After Image >
netlify[bot] commented 1 year ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit 5137c80523db1ac92292e85e943dfddca77452c1
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/65229a8911e3ed0008495943
Deploy Preview https://deploy-preview-36--frontend-database.netlify.app/projects/typing_game
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Hey there! I've created a report for the pull request. Let's dive in!

Changes

  1. Added a new project called "Typing Speed Game" by Krishna Mundada.
  2. Added the project details to the ProjectList.json file.
  3. Added the app.js file for the Typing Speed Game.
  4. Added the index.html file for the Typing Speed Game.
  5. Added the style.css file for the Typing Speed Game.

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

  1. In the app.js file, consider using more descriptive variable names instead of main, typeArea, and btn.
  2. In the app.js file, consider extracting the array of words into a separate file for better organization and reusability.
  3. In the app.js file, consider using const instead of let for the randText variable in the play function.
  4. In the app.js file, consider using template literals instead of concatenation in the end function to improve readability.
  5. In the app.js file, consider adding error handling for cases where the user input does not match the expected format.

Rating

I would rate the code a 7 out of 10 based on the following criteria:

That's it for the pull request report! Let me know if you need any further assistance. Have a great day!

dev-AshishRanjan commented 1 year ago

You can also checkout our Idea-Arca, the project idea bank for any languages, for open-source contributions.

Happy Contributing season! Keep up the good work!