dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2024 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
18 stars 41 forks source link

add color selector #53

Closed VishnuSandeep1108 closed 1 year ago

VishnuSandeep1108 commented 1 year ago

Describe your change:

Checklist:

netlify[bot] commented 1 year ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit a7853c4c84fba9ffa9cdd4b515335efb90931689
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/652ac57808d3b000081f4d7e
Deploy Preview https://deploy-preview-53--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Hey there! 👋 Here's the report for the pull request:

Changes

  1. Modified ProjectList.json:
    • Added a new project called "Color Selector" by Vishnu Sandeep.
    • Updated the description of the "Finance Graph" project.

Suggestions

No suggestions provided.

Bugs

No bugs found.

Improvements

  1. In the index.html file of the "Color Selector" project:

    • Line 14: Remove the empty title tag.
    • Line 16: Add a space after the media attribute in the style tag.
    • Line 23: Move the closing </div> tag to a new line for better readability.
    • Line 29: Add a space after the opening <table> tag.
    • Line 30: Add a space after the opening <tr> tag.
    • Line 31-45: Add a space after the opening <td> tag in each row.
    • Line 46: Add a space after the opening <tr> tag.
    • Line 47: Add a space after the opening <td> tag in each row.
    • Line 48: Add a space after the opening <tr> tag.
    • Line 49: Add a space after the opening <td> tag in each row.
  2. In the index.js file of the "Color Selector" project:

    • Line 1: Add a space after the let keyword.
    • Line 2: Add a space after the = operator.
    • Line 4: Add a space after the forEach method.
    • Line 5: Add a space after the addEventListener method.
    • Line 6: Add a space after the => arrow function.
    • Line 7: Add a space after the const keyword.
    • Line 9: Add a space after the = operator.

Rating

I would rate the code a 7 out of 10 based on the following criteria:

That's it for the report! Let me know if you need any further assistance. 😄

dev-AshishRanjan commented 1 year ago

You can also checkout our Idea-Arca, the project idea bank for any languages, for open-source contributions. The PR from this repo is being accepted in hacktoberfest2023

Happy Contributing season! Keep up the good work!