dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
14 stars 37 forks source link

Added a BMI Calculator #56

Closed kshitizvardhan closed 8 months ago

kshitizvardhan commented 8 months ago

Describe your change: Added a BMI Calculator

Checklist:

ATTACH SCREEN-SHOTS

Before After
< Before Image > < After Image >

Screenshot 2023-10-15 195239

netlify[bot] commented 8 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit a187ba1de55354e06b502992f737302ee66b81a4
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/652bf5ebad1c9f0008ef2258
Deploy Preview https://deploy-preview-56--frontend-database.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pr-explainer-bot[bot] commented 8 months ago

Pull Request Review

Hey there! πŸ‘‹ Here's a summary of the previous results for the pull request review. Let's dive in!

Changes

  1. Added a new project 'BMI Calculator' to the ProjectList.json file.
  2. Added the necessary details for the 'BMI Calculator' project.
  3. Added the file path for the 'BMI Calculator' project.
  4. Added a description for the 'BMI Calculator' project.

Suggestions

  1. In line 34, consider adding a background-size property to control the size of the background image.
  2. In line 45, consider adding a transition property to control the transition effect on hover.
  3. In line 56, consider adding a min-height property to ensure the panel has a minimum height.
  4. In line 68, consider adding a margin-bottom property to create some space between the form and the panel.
  5. In line 79, consider adding a margin-top property to create some space between the button and the form.
  6. In line 92, consider adding a margin-top property to create some space between the results and the form.

Bugs

  1. The file 'ProjectList.json' may have a missing comma after the 'tags' array in line 11.
  2. The file 'index.html' may have a missing comma after the 'background-repeat' property in line 32.
  3. The file 'index.html' may have a missing comma after the 'background-image' property in line 33.
  4. The file 'index.html' may have a missing comma after the 'background-color' property in line 34.
  5. The file 'index.html' may have a missing comma after the 'outline' property in line 36.
  6. The file 'index.html' may have a missing comma after the 'margin-bottom' property in line 37.
  7. The file 'index.html' may have a missing comma after the 'text-decoration' property in line 43.
  8. The file 'index.html' may have a missing comma after the 'color' property in line 44.
  9. The file 'index.html' may have a missing comma after the 'transition' property in line 45.
  10. The file 'index.html' may have a missing comma after the 'cursor' property in line 46.
  11. The file 'index.html' may have a missing comma after the 'text-shadow' property in line 47.
  12. The file 'index.html' may have a missing comma after the 'width' property in line 54.
  13. The file 'index.html' may have a missing comma after the 'padding' property in line 55.
  14. The file 'index.html' may have a missing comma after the 'border' property in line 56.
  15. The file 'index.html' may have a missing comma after the 'margin-bottom' property in line 57.
  16. The file 'index.html' may have a missing comma after the 'background-color' property in line 58.
  17. The file 'index.html' may have a missing comma after the 'outline' property in line 59.
  18. The file 'index.html' may have a missing comma after the 'color' property in line 60.
  19. The file 'index.html' may have a missing comma after the 'font-size' property in line 61.
  20. The file 'index.html' may have a missing comma after the 'border' property in line 68.
  21. The file 'index.html' may have a missing comma after the 'background-color' property in line 69.
  22. The file 'index.html' may have a missing comma after the 'border-radius' property in line 70.
  23. The file 'index.html' may have a missing comma after the 'animation-name' property in line 71.
  24. The file 'index.html' may have a missing comma after the 'animation-duration' property in line 72.
  25. The file 'index.html' may have a missing comma after the 'animation-timing-function' property in line 73.
  26. The file 'index.html' may have a missing comma after the 'animation-delay' property in line 74.
  27. The file 'index.html' may have a missing comma after the 'animation-iteration-count' property in line 75.
  28. The file 'index.html' may have a missing comma after the 'animation-fill-mode' property in line 76.

Improvements

  1. Added a new HTML file 'index2.html' with 111 lines of code.
  2. Line 14: Instead of using inline styles, consider moving the CSS code to an external stylesheet for better code organization.
  3. Line 38: The closing </ul> tag is missing in the navigation section. Add it to fix the HTML structure.
  4. In the CSS code, lines 45-48 can be refactored for better readability by using shorthand properties. Instead of specifying each individual property, you can use the margin property to set all four margins at once. Here's the refactored code snippet:
.content {
  border: 1px solid yellowgreen;
  padding: 25px;
  margin: 20px;
  width: 50%;
  border-radius: 20px 0px 20px 0px;
  background-color: rgba(153, 205, 50, 0.651);
  height: 150px;
  position: relative;
  left: 652px;
  top: 160px;
}

Rating

Rating: 8/10

Criteria:

That's it for the summary! Feel free to reach out if you have any questions or need further assistance. Happy coding! πŸ˜„πŸš€

dev-AshishRanjan commented 8 months ago

You can checkout our Idea-Arca, the project idea bank for any languages, for open-source contributions. The PR from this repo is being accepted in hacktoberfest2023

Happy Contributing season! Keep up the good work!