dev-AshishRanjan / Hacktoberfest-Frontend

Make your Pull Request for Hacktoberfest 2023 in the Web domain specially Frontend. And give this repo a ⭐
https://frontend-database.netlify.app
MIT License
15 stars 36 forks source link

Portfolio website and update ProjectList Fixes #58 #59

Closed RAGHAVS1304 closed 11 months ago

RAGHAVS1304 commented 11 months ago

Describe your change:

Checklist:

ATTACH SCREEN-SHOTS

Before After

Screenshot 2023-10-18 183846 | < After Image > |

netlify[bot] commented 11 months ago

Deploy Preview for frontend-database ready!

Name Link
Latest commit c72e07327f33c41f9f18577932167d80d648b178
Latest deploy log https://app.netlify.com/sites/frontend-database/deploys/652fd9df7b763f0008d9b443
Deploy Preview https://deploy-preview-59--frontend-database.netlify.app/projects/portfolio
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

RAGHAVS1304 commented 11 months ago

Sir i have raised the PR, please review it. Thanks.

pr-explainer-bot[bot] commented 11 months ago

Pull Request Review Markdown Doc

Hey there! 👋 Here's a summary of the previous results and tasks for the pull request review:

Changes:

  1. Added a new project 'Portfolio Website' by Raghav Sharma.
  2. Added a new file 'index.html' in the 'projects/Portfolio' directory.
  3. Added CSS file 'style.css' in the 'projects/Portfolio' directory.
  4. Added images 'background.png', 'favicon.png', and 'main.jpg' in the 'projects/Portfolio/img' directory.

Suggestions to Improve Code:

  1. In line 9 of 'index.html', consider using a relative path for the favicon image instead of an absolute path.
  2. In line 19 of 'index.html', consider using a relative path for the stylesheet 'style.css' instead of an absolute path.
  3. In line 21 of 'index.html', consider using a preconnect link for the Google Fonts API to improve performance.
  4. In line 23 of 'index.html', consider using a preconnect link for the Font Awesome CDN to improve performance.
  5. In line 34 of 'index.html', consider using semantic HTML tags like <header> instead of <div> for the navigation section.
  6. In line 47 of 'index.html', consider using a <button> element instead of an <a> element for the 'Subscribe' button.
  7. In line 61 of 'index.html', consider using a <button> element instead of an <a> element for the 'Let's Start' button.
  8. In line 85 of 'index.html', consider using a <button> element instead of an <a> element for the 'Let's Talk' button.
  9. In line 108 of 'index.html', consider using a <button> element instead of an <a> element for the 'Read More' button.
  10. In line 130 of 'index.html', consider using a <button> element instead of an <a> element for the 'Read More' button.
  11. In line 152 of 'index.html', consider using a <button> element instead of an <a> element for the 'Read More' button.
  12. In line 166 of 'index.html', consider using a <button> element instead of an <a> element for the 'Hire Me' button.

Potential Bugs:

  1. In line 9 of 'index.html', the path for the favicon image might be incorrect or missing.
  2. In line 19 of 'index.html', the path for the stylesheet 'style.css' might be incorrect or missing.
  3. In line 21 of 'index.html', the preconnect link for the Google Fonts API might not be working.
  4. In line 23 of 'index.html', the preconnect link for the Font Awesome CDN might not be working.
  5. In line 34 of 'index.html', the navigation section might not have the correct HTML structure.
  6. In line 47 of 'index.html', the 'Subscribe' button might not have the correct HTML element.
  7. In line 61 of 'index.html', the 'Let's Start' button might not have the correct HTML element.
  8. In line 85 of 'index.html', the 'Let's Talk' button might not have the correct HTML element.
  9. In line 108 of 'index.html', the 'Read More' button might not have the correct HTML element.
  10. In line 130 of 'index.html', the 'Read More' button might not have the correct HTML element.
  11. In line 152 of 'index.html', the 'Read More' button might not have the correct HTML element.
  12. In line 166 of 'index.html', the 'Hire Me' button might not have the correct HTML element.

Improvements:

In the 'index.html' file, the code for the navigation section (lines 34-42) could be refactored for better readability and maintainability. Here's a suggested improvement:

<nav>
  <h2 class='logo'>Portfo<span>lio</span></h2>
  <ul>
    <li><a href='#'>Home</a></li>
    <!-- more navigation items -->
  </ul>
</nav>

Rating:

Code Rating: 7/10 Criteria: Readability, Performance, Security

Commit History:

That's it! Feel free to review and provide any additional feedback. 😄

dev-AshishRanjan commented 11 months ago

You can checkout our Idea-Arca, the project idea bank for any languages, for open-source contributions. The PR from this repo is being accepted in hacktoberfest2023

Happy Contributing season! Keep up the good work!

RAGHAVS1304 commented 11 months ago

The PR from this repo is being accepted in hacktoberfest2023

Thanks sir for accepting my PR, it was nice contributing in this repo. Sir i just want to confirm if this repo is still in hacktoberfest 2023, because i checked on the website it showed that this repo is excluded.vPlease confirm sir. Thanks once again.

dev-AshishRanjan commented 11 months ago

This repo has been recently excluded from hacktoberfest

But Idea-Arca is being accepted