search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
42 stars 18 forks source link

CMake printouts of git_info ? #129

Closed miroi closed 9 years ago

miroi commented 9 years ago

Hi,

shouldn't we have some CMake printouts (message ...) from the git_info module ?

https://github.com/scisoft/autocmake/blob/master/modules/git_info/git_info_sub.cmake

Like previously in DIRAC, see for example https://testboard.org/cdash/buildSummary.php?buildid=21035 , we printed out git status variables to ease CDash tests control.

bast commented 9 years ago

I think this would not harm.

miroi commented 9 years ago

Well, after thinking a little more I am against printing from git_info.

Why ? The cmake output must be consistent and esthetic, and git_info data should go smoothly after build_info printout. See for example https://testboard.org/cdash/buildSummary.php?buildid=32894 (though git_info is not printed out there).

Comments ?

bast commented 9 years ago

Not having the printout is fine for me, too. Closing the issue then.