search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
42 stars 18 forks source link

Too many tests broken or deactivated on Windows #167

Closed bast closed 8 years ago

bast commented 8 years ago

@miroi I am considering dropping automated testing on Appveyor because many of the corresponding tests are broken or deactivated. Nobody seems to have time or means to work on it. I don't see the value of such tests. What do you think?

miroi commented 8 years ago

As long as autocmake is beeing used with MS Windows, let us keep the tests.

Currently https://ci.appveyor.com/project/bast/autocmake tests are not even starting due to missing git...

bast commented 8 years ago

But what is the value of keeping them?

miroi commented 8 years ago

The value of (Windows working) tests is that they serve as working examples, which can be adapted for users purposes.

bast commented 8 years ago

Then they should not be tests but move to the documentation, right?

bast commented 8 years ago

And I don't think they serve as working examples because they are not working.

bast commented 8 years ago

Just to be clear I am not suggesting that we should stop supporting Windows. Python is cross-platform and CMake is cross-platform so Autocmake is cross-platform. I am just suggesting that we should stop the testing since it does not serve us anything. Many tests are deactivated and many active tests are broken. I don't see any value in that. I really appreciate your work on Windows integration and we should not stop this. I just think that we should test only on Linux and Mac for the moment. This is because I have no way to develop and test on Windows myself and you are busy too. We should focus our efforts. We should continue supporting Windows via issues. If there are problems, then we will know via issues.

bast commented 8 years ago

Miro, I think I will get rid of the automated Windows tests but if you like you can maintain a fork which focuses on Windows tests. However, I want to keep supporting Windows via issues. I believe with this we will be able to move faster while keeping portability.

miroi commented 8 years ago

Go ahead - I created own branch for supporting Windows, https://github.com/miroi/autocmake/tree/windows_supp .