search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
41 stars 18 forks source link

C++11 in default GNU C++ plugin #198

Closed robertodr closed 7 years ago

robertodr commented 7 years ago

Should the default GNU C++ plugin use the -std=c++11 flag? https://github.com/coderefinery/autocmake/blob/master/compilers/GNU.CXX.cmake

bast commented 7 years ago

I thought at some point that it was a good idea. But apparently not? Would you prefer this not to be a default flag?

robertodr commented 7 years ago

I am not sure. Sadly enough, C++11 compliance still crosses out a lot of proprietary compilers from being usable.

bast commented 7 years ago

OK - for consistency it would then make sense to take it out, right?

robertodr commented 7 years ago

That would be my preferred solution. There can be an extra plugin to adjust the C++ standard version, which would check compiler version and standard library, like here The plugin should only kick in if the CMake version is less than 3.0, however.

bast commented 7 years ago

I agree - I will remove the flag shortly.

robertodr commented 7 years ago

thanks! :+1: