search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
41 stars 18 forks source link

Setup script should check return code of configure step #220

Open bast opened 6 years ago

bast commented 6 years ago

Instead of doing this: https://github.com/coderefinery/autocmake/blob/master/autocmake/configure.py#L113-L118 which is brittle.

miroi commented 6 years ago

Hi Rado,

def save_setup_command(argv, build_path)

is very useful function, because ordinary software users sometimes forget what exact form of setup command did they use.

For example, in DIRAC "./setup --mpi --fc=mpif90 --cc=mpicc --cxx=mpiCC --int64 --extra-fc-flags=-xHost --extra-cc-flags=-xHost --extra-cxx-flags=-xHost build_openmpi_intelmkl_i8_xh"

The setup_command file is missing '' . Would be good to add apostrophe.

bast commented 6 years ago

I think your suggestion is unrelated to the topic of this issue. Can you please open a new issue? Also in your issue please show what the command prints out now and what you would like to print instead. Thank you.