search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
41 stars 18 forks source link

Write cmake_output under build_path #222

Closed robertodr closed 6 years ago

robertodr commented 6 years ago

cmake_output was written to the root directory instead of under build_path.

bast commented 6 years ago

Interesting! How come we never noticed? Is this new? The os.path.join paths should I think be comma-separated.

robertodr commented 6 years ago

It happened because of my last change. We are not moving anymore into the build directory, just running CMake outside of it with -B<build_path> -H. hence the cmake_output file is "orphaned"

On Fri, Dec 15, 2017 at 11:26 AM, Radovan Bast notifications@github.com wrote:

Interesting! How come we never noticed? Is this new? The os.path.join paths should I think be comma-separated.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/coderefinery/autocmake/pull/222#issuecomment-352048783, or mute the thread https://github.com/notifications/unsubscribe-auth/ADiXESgpUqS0fknOx19kFBKavjPotUvgks5tAp3SgaJpZM4RDsuS .

-- Roberto Di Remigio

robertodr commented 6 years ago

You can squash the two commits if you'd like

bast commented 6 years ago

Thanks a lot for the fix!