search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
42 stars 18 forks source link

adjust XL Fortran OMP flag; fixes #232 #233

Closed bast closed 6 years ago

bast commented 6 years ago

Can you please look over this @robertodr?

bast commented 6 years ago

Hmm. Yes, that would be even better. Thanks. One thing that starts to bother me a bit is the diffuse versioning in Autocmake but that is a separate issue. We need to think about it.

bast commented 6 years ago

One problem that I see with this is that FindOpenMP.cmake potentially pulls in other modules (I haven't tested this but see this happening with FindMPI.cmake. I think we should merge this since it's better than before but I think that offloading to FindOpenMP.cmake is not so trivial.

robertodr commented 6 years ago

Agreed that this is better than nothing.

On Wed, Mar 7, 2018, 12:36 Radovan Bast notifications@github.com wrote:

One problem that I see with this is that FindOpenMP.cmake potentially pulls in other modules (I haven't tested this but see this happening with FindMPI.cmake. I think we should merge this since it's better than before but I think that offloading to FindOpenMP.cmake is not so trivial.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coderefinery/autocmake/pull/233#issuecomment-371111412, or mute the thread https://github.com/notifications/unsubscribe-auth/ADiXEft9_T6AUvzxG--j4_IrCrHZftmZks5tb8ZFgaJpZM4SgEWC .