search

dev-cafe / autocmake

CMake plugin composer.
http://autocmake.org
BSD 3-Clause "New" or "Revised" License
42 stars 18 forks source link

Do not blanket-set include dirs and link libs #235

Closed robertodr closed 6 years ago

robertodr commented 6 years ago

Not all targets in the project necessarily depend on Python.h and libpython.

bast commented 6 years ago

Good catch! Ugly stuff is going on in there :-) We need to revamp it :-)

robertodr commented 6 years ago

Agreed :smile:

On Fri, Mar 9, 2018 at 7:06 PM, Radovan Bast notifications@github.com wrote:

Good catch! Ugly stuff is going on in there :-) We need to revamp it :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/coderefinery/autocmake/pull/235#issuecomment-371895908, or mute the thread https://github.com/notifications/unsubscribe-auth/ADiXEQzaDsyw6IEtoE63C68U5ggJr0nUks5tcsSigaJpZM4SkpF7 .

-- Roberto Di Remigio

robertodr commented 6 years ago

What do you say we use the find Python libs module in PyBind11?

bast commented 6 years ago

The python tests are now new failing tests. Would you like me to look into that or will you have a look?

bast commented 6 years ago

About pybind11: you mean in the book?

robertodr commented 6 years ago

I meant copy-pasting this module into Autocmake: https://github.com/pybind/pybind11/blob/master/tools/FindPythonLibsNew.cmake It seems to be able to consistently find the right version of libraries given an interpreter (which the standard CMake module still struggles with) I'll look into the tests, I had committed though the web UI.

bast commented 6 years ago

Thanks! Now I understand - yes, sounds good.

bast commented 6 years ago

Thanks!