dev-cafe / cmake-cookbook

CMake Cookbook recipes.
Other
2.71k stars 696 forks source link

STYLE: Remove ingored FATAL_ERROR flag #517

Closed hjmjohnson closed 4 years ago

hjmjohnson commented 4 years ago

The FATAL_ERROR flag for cmake_minimum_required is silently ignored since cmake 2.6.0.

Description

Minor style update for cmake_minimum_version

Motivation and Context

Modernize example code to match API of CMake > 3.0

How Has This Been Tested?

Extensively in many other packages.

Types of changes

Style change to remove the unnecessary ignored flag.

Status

bast commented 4 years ago

Dear Hans, thanks for the patch! I admit I did not know until now :-) I need to wait few days until I have time to revive the automated testing and then I can merge it.

hjmjohnson commented 4 years ago

Dear Hans, thanks for the patch! I admit I did not know until now :-) I need to wait few days until I have time to revive the automated testing and then I can merge it.

I hope to someday have time to make other minor contributions to the book. Great work!

hjmjohnson commented 4 years ago

@bast PING: Have you had any luck reviving the dashboard? Can this be merged as is?

robertodr commented 4 years ago

@hjmjohnson thanks again for this contribution. Both @bast and I are sadly swamped and reviving the dashboard is at least one full week worth of work. I think this can however be merged as-is.

robertodr commented 4 years ago

You should follow these guidelines and sign-off your commit. This is needed for the developer certificate of origin (DCO)

hjmjohnson commented 4 years ago

Done

You should follow these guidelines and sign-off your commit. This is needed for the developer certificate of origin (DCO)

Done.

bast commented 4 years ago

Also apologies from me. Reviving the automated testing will indeed be a couple of days of work and I had to postpone that to ... unclear when :-) But we really appreciate your contribution!

robertodr commented 4 years ago

@bast I'll merge if you have no further review comments.