search

dev-cafe / parselglossy

Generic input parsing library, speaking in tongues.
https://parselglossy.readthedocs.io
MIT License
7 stars 2 forks source link

GitHub Action producin PyPI package does not trigger on release #103

Closed robertodr closed 4 years ago

robertodr commented 4 years ago

I prepared and published v0.5.0, but the action was not triggered and thus no PyPI package uploaded.

bast commented 4 years ago

Weird ... looking at it.

bast commented 4 years ago

First time I see this not working. I tried it here and it works: https://github.com/bast/just-testing/actions (same repo just pushed to a new address).

So how did you create the release? Apparently differently than what I do.

bast commented 4 years ago

Is GitHub confused about a leftover workflow with the same name?

robertodr commented 4 years ago

I think I tagged by hand, rather than through the web UI. And it happened through Travis. We never tagged after switching to GH actions and the workflow was never tested.

bast commented 4 years ago

I always use web UI these days for releases so maybe something is missing for when tags are pushed via command line. I will test that in my throwaway repo.

bast commented 4 years ago

Confirmed: this doesn't do anything when a tag is pushed. I don't know, let's create them through web UI?

robertodr commented 4 years ago

But 0.5.0 was created through the web UI

On Sat, Aug 15, 2020, 17:27 Radovan Bast notifications@github.com wrote:

Confirmed: this doesn't do anything when a tag is pushed. I don't know, let's create them through web UI?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dev-cafe/parselglossy/issues/103#issuecomment-674411394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JOEM2463NWJMJVGAUXOTSA2SMRANCNFSM4QAJWEIA .

bast commented 4 years ago

Then it's some interaction with leftover workflow from earlier? I don't know. It should work and works in other repos.

robertodr commented 4 years ago

Could it be that the master test action was not successful? The trigger for packaging remained the same with the earliest iteration of the workflow and the current...

On Sat, Aug 15, 2020, 17:59 Radovan Bast notifications@github.com wrote:

Then it's some interaction with leftover workflow from earlier? I don't know. It should work and works in other repos.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dev-cafe/parselglossy/issues/103#issuecomment-674415597, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4JOEJHM5EM76UK2RL3JD3SA2WG5ANCNFSM4QAJWEIA .

bast commented 4 years ago

I don't understand it :man_shrugging:

robertodr commented 4 years ago

I don't know what I did wrong yesterday. I have just now removed the v0.5.0 tag and tagged a v0.5.0-rc1. Both the testing and packaging actions have been triggered.

Packaging fails because I forgot to update the version in __init__.py :facepalm:

robertodr commented 4 years ago

Everything works as it should now. Yay! :confetti_ball:

bast commented 4 years ago

Cool!