Consolidate specification of dependencies

dev-cafe / parselglossy

Generic input parsing library, speaking in tongues.

https://parselglossy.readthedocs.io

MIT License

7 stars 2 forks source link

Consolidate specification of dependencies #22

Closed robertodr closed 5 years ago

robertodr commented 5 years ago

We have dependencies for development (specified in Pipfile), testing (installed with pip on CI services, see the YAML files), and deployment (installed with pip install parselglossy). This is problematic as we can easily lose track of dependencies in this way.

bast commented 5 years ago

One way would be to put everything into setup.py but then the user will pull in dependencies they don't need.

Probably we will need two places. But we should try to remove explicit dependencies from the CI recipe files.

robertodr commented 5 years ago

Possible solutions:

List everything in setup.py and do pip install -e . on CI. Drawback:
1. installing the published package would pull in pytest and company.
2. We still need the Pipfile to install development tools like the language server and mypy.
On CI do pipenv install --dev -e .. Drawback: CI runs in virtual environment already.

bast commented 5 years ago

On CI do pipenv install --dev -e .. Drawback: CI runs in virtual environment already.

I am not sure I see the problem with this approach.

robertodr commented 5 years ago

Actually, no drawbacks, just a warning from Pipenv that it will not create a new virtual environment.